Skip to content

London | 26-ITP-Jan | Damian Dunkley | Sprint 2 | Form-Controls #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DamianDL wants to merge 17 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Jan | Damian Dunkley | Sprint 2 | Form-Controls #1027

DamianDL wants to merge 17 commits into from
+56 −8

Conversation

@DamianDL
Copy link

@DamianDL DamianDL commented Jan 23, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

How to save attributes

Questions

No outstanding questions yet

@netlify
Copy link

netlify bot commented Jan 23, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit f8ded79
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697c80268c8da2000878dd1f
😎 Deploy Preview https://deploy-preview-1027--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 87 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@DamianDL DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 23, 2026
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL DamianDL added the ⚙️ bug Something isn't working label Jan 26, 2026
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL
Copy link
Author

DamianDL commented Jan 26, 2026

Please can I have some help.

  1. I have managed to revert the branch back to the initial commit, but cannot revert it back to the original Wireframe files.. I have done this using the git revert . Where can I find the hex id for the unchanged branch? Or should I use another command/approach? Thanks.

@DamianDL DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed ⚙️ bug Something isn't working labels Jan 27, 2026
@DamianDL
Copy link
Author

DamianDL commented Jan 29, 2026

Updated with changes to meet requirements;

  • I have used HTML only.
  • I have not used any CSS or JavaScript.

HTML

  • My form is semantic html.
  • All inputs have associated labels.
  • My Lighthouse Accessibility score is 100.
  • I require a valid name. I have defined a valid name as a text string of two characters or more.
  • I require a valid email of the format "texx@text.text"
  • I require one colour from a defined set of 3 colours.- Red, Blue, Green
  • I require one size from a defined set of 6 sizes. -XS, S, M, L, XL, XXL

@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 29, 2026
cjyuan
cjyuan reviewed Jan 29, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://validator.w3.org/, there are errors in your code. Can you fix them?

Form-Controls/index.html Outdated
<div>
<!-- Email: basic format text@text.text -->
<label for="email">Email:</label>
<input type="email" id="email" name="email" required pattern="^[^@\s]+@[^@\s]+\.[^@\s]+$" title="Enter a valid email like user@example.com">
Copy link
Contributor

@cjyuan cjyuan Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use pattern in <input type="email"> when browsers can already perform built-in email validation?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 29, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Jan 29, 2026

In the Changelist section of the PR description, I am not sure what you mean by "How to save attributes". Can you update it accordingly to give a brief but clearer description of what you have changed in this PR branch?

@DamianDL
Copy link
Author

DamianDL commented Jan 30, 2026

CJ-Thanks for your clear and concise review. I believe that I have made changes to align with your comments. Thanks Damian

@DamianDL DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
cjyuan
cjyuan reviewed Jan 30, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

Code is good, but the indentation of the code could use some improvement.

2

In the Changelist section of the PR description, I am not sure what you mean by "How to save attributes". Can you update it accordingly to give a brief but clearer description of what you have changed in this PR branch?

Form-Controls/index.html
label {
font-size: 24px;
}
</style>
Copy link
Contributor

@cjyuan cjyuan Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve the indentation on lines 10, 41, 71-72?

You can use the VSCode's "Format Document" feature to auto-indent the code?
To use the feature, right-click inside the code editor and select the option.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DamianDL @cjyuan